search

kkrt-labs / kakarot-rpc

Kakarot ZK EVM Ethereum RPC adapter
MIT License
135 stars 91 forks source link

dev: add a way to dynamically set the kakarot block gas limit in the hive chain binary #838

Open Eikix opened 7 months ago

Eikix commented 7 months ago

https://github.com/kkrt-labs/kakarot-rpc/pull/833#discussion_r1515849144

greged93 commented 1 week ago

@Eikix this needs scoping

Eikix commented 1 week ago

@Eikix this needs scoping

I don't remember the context / need; are you able to scope this issue if it is still needed?

greged93 commented 1 week ago

The idea is that we don't have a way to set the gas limit in the contract dynamically, meaning it will just be fixed to a certain value, without taking into account L1 gas fluctuations. The initial idea was to have a service update this value but this was never further scoped

Eikix commented 1 week ago

The idea is that we don't have a way to set the gas limit in the contract dynamically, meaning it will just be fixed to a certain value, without taking into account L1 gas fluctuations. The initial idea was to have a service update this value but this was never further scoped

What does it unlock that is currently locked? Test accuracy? Some tests fail because of it?

greged93 commented 1 week ago

No just better transaction cost on chain. If you don't do this and we charge a base fee of 1 Gwei while L1 cost is 1000Gwei, it will cause a big missprice between the Starknet cost the relayer pays on Sepolia and the actual cost which is paid to the coinbase.

Eikix commented 1 week ago

But this is for hive chain binary

greged93 commented 1 week ago

oh my bad, then is more a tracking issue then, in case we ever need to dynamically set the block gas limit in the hive tests. For now since hive tests are locked to a specific commit because of this issue, there is nothing to do.