Open Eikix opened 11 months ago
also, update readme afterwards
if need be, modify devcontainer
blocked by a discrepancy between snforge and scarb that'll be resolved once cairo 2.1 is released
we need #[should_panic]
before, I made a PR to starknet-foundry to have it available (probably next week). There will be no changes to do.
@enitrat tried to migrate to sn foundry on august 18th and found it impractical -> contract first approach, must deploy contracts to test functions
-> contract first approach, must deploy contracts to test functions
Not necessarily but if you want to mock stuff, then you need to do that (unlike cairo-test)
-> contract first approach, must deploy contracts to test functions
Not necessarily but if you want to mock stuff, then you need to do that (unlike cairo-test)
Not sure I understand
Basically, imagine you want to test is_caller_eoa
. To do that you want to mock the caller address, create your execution context, and then call is_caller_eoa
. This is not possible in the current state of SN Foundry, because you can't mock global variables unless you explicitly interact with a deployed contract
see discussion here https://github.com/foundry-rs/starknet-foundry/pull/462
I see! Thanks
Important update: we are gathering some bugs in the Kakarot v0 codebase, we need to make sure each issue and each PR in Kakarot-ssj is aware of the lists of known bugs. Look at this link everytime you take an issue and check your issue isn't targeted by a known bug.
Important update: we are gathering some bugs in the Kakarot v0 codebase, we need to make sure each issue and each PR in Kakarot-ssj is aware of the lists of known bugs. Look at this tracking issue everytime you take an issue and check your issue isn't targeted by a known bug. Will add this reminder in many places to make sure we keep track of known bugs.
Feature Request
exploratory issue -> go through the tutorial and migrate from scarb to sn foundry
we're not using smart contracts yet so no big change