search

kkrt-labs / kakarot-ssj

Kakarot zkEVM - rewrite in the latest version of Cairo
https://www.kakarot.org
MIT License
132 stars 67 forks source link

feat: support SNIP-9 on account contracts #819

Closed enitrat closed 4 days ago

enitrat commented 1 month ago

See https://github.com/kkrt-labs/kakarot/blob/7fb90d799a5a0bfab0a48bdfcb4e867d35b4943c/src/kakarot/accounts/account_contract.cairo#L83

remybar commented 1 month ago

Can I work on this ?

Some info I found:

onlydustapp[bot] commented 1 month ago

Hey @remybar! Thanks for showing interest. We've created an application for you to contribute to Kakarot zkEVM. Go check it out on OnlyDust!

enitrat commented 1 month ago

yes, and the reference implementation in Cairo Zero: https://github.com/kkrt-labs/kakarot/blob/7fb90d799a5a0bfab0a48bdfcb4e867d35b4943c/src/kakarot/accounts/account_contract.cairo#L83.

First try to migrate to a SNIP-9 compatible structure. For everything that can not trivially implemented, add a TODO and we'll create an issue.

enitrat commented 3 weeks ago

@remybar how are things going?

remybar commented 3 weeks ago

@remybar how are things going?

Hi @enitrat We finally took some holidays until end of August so I'll be back to work on issues end of August/beginning of September.

Do you need this feature earlier than that? If yes, I can push what I did if someone wants to continue.

enitrat commented 3 weeks ago

yes please!

remybar commented 3 weeks ago

yes please!

I pushed what I've started in the following PR https://github.com/kkrt-labs/kakarot-ssj/pull/836.

Sorry for the delay, I don't like to start a task and let it for several days/weeks 😕