fix: increment pc post-opcode execution - Githubissues

kkrt-labs / kakarot-ssj

Kakarot zkEVM - rewrite in the latest version of Cairo

https://www.kakarot.org

MIT License

137 stars 83 forks source link

fix: increment pc post-opcode execution #955

Closed enitrat closed 2 months ago

enitrat commented 2 months ago

Pull Request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Resolves: #

What is the new behavior?

Fixes an issue where PC should be incremented AFTER opcode execution, not before
(skip increment for JUMP family opcodes)

Does this introduce a breaking change?

[ ] Yes
[ ] No

This change is