search

kkrt-labs / kakarot

Kakarot is a zkEVM written in Cairo, leveraging the STARK proof system.
https://kakarot.org
MIT License
959 stars 275 forks source link

feat: use `sha256` syscall from Cairo1Helpers class #1335

Open enitrat opened 1 month ago

enitrat commented 1 month ago

see https://github.com/kkrt-labs/kakarot-ssj/pull/813

adrianvrj commented 1 month ago

Hey, can I work on this?

onlydustapp[bot] commented 1 month ago

Hey @adrianvrj! Thanks for showing interest. We've created an application for you to contribute to Kakarot zkEVM. Go check it out on OnlyDust!

enitrat commented 1 month ago

Hi @adrianvrj, thank you for your interest. Only issues marked as such are open for contributions

obatirou commented 1 month ago

Seems to be a duplicate from https://github.com/kkrt-labs/kakarot/issues/1311 ?

enitrat commented 1 month ago

oops yes, although now it's feasible

ClementWalter commented 4 days ago

where should this be used in the current codebase? still relevant?

obatirou commented 2 days ago

where should this be used in the current codebase? still relevant?

It should replace the precompiles sh256 as it is more optimized. It will also reduce the cairo0 code used to rely on the syscall https://community.starknet.io/t/cairo-v2-7-0-is-coming/114362