search

kkszysiu / mifm

The roidmi app english apk
29 stars 13 forks source link

Google translated the strings_en xml. Only the chinese part is translated. #2

Closed mdavid5 closed 8 years ago

mdavid5 commented 8 years ago

I've reviewed the file after the translation and corrected the formatting mistakes made by the translation process.

vivalaflam commented 8 years ago

This is not the final version of the translation. I fixed all issues as I'm a native English speaker, and I translated chinese as well.

vivalaflam commented 8 years ago

I mean next version is gonna feature my english translation, which pretty much is similar to your thing, apart, I formatted the chinese translation manually, without Google translate

mdavid5 commented 8 years ago

This sounds good :) I did't know there is somebody working on the translation who speaks Chinese. (Yes this version is a bit barbaric... but I've finished the "translation" in 30 minutes)

vivalaflam commented 8 years ago

There are indeed some minor grammar mistakes in the chinese terms of service, but the formatting is correct. (the file I uploaded is not uploadable because I used wordpad, but hopefully, the author will input the strings exactly how I wrote them.)

Also, one more thought, is to change the app's name. change it from "car bluetooth fm" to something like RoidMi or Xiaomi RoidMi or something similar

mdavid5 commented 8 years ago

I see you didn't fork the original repository :) (I guess you are not a coder guy) You can validate the xml you made with online tools too if you don't have any coding editor. Like this one: https://validator.w3.org/feed/#validate_by_input

If everything is ok with your translation then the only error this tool will say is this (because it expects html not a resource file): line 2, column 0: Undefined root element: resources

vivalaflam commented 8 years ago

Actually I'm an IT engineer, at least I'm studying it :P I just downloaded the xml and edited it with wordpad. Last time I checked that was good enough for all the app translations I've done (android assistant being the most popular one)

mdavid5 commented 8 years ago

Haha sorry :) Then why don't you make a fork modify the file and make a pull request? The author suggest that to contribute. This way he doesn't have to make things manually (the Travis CI builder will validate your work too)

vivalaflam commented 8 years ago

I made a github account just for this, havent actually gotten around on how to use it -- yet. no time

ihortymoshenko commented 8 years ago

@kkszysiu, I think this PR is no longer needed

P.S. Can you make the new release? Thanks!