search

kkujansuu / gramps

MIT License
1 stars 1 forks source link

Close button: support to remember the user having an unsaved modified filter #28

Open HelgeGitHub opened 1 year ago

HelgeGitHub commented 1 year ago

It would be helpful for the user if there would be support if the user closes the main dialogue without saving changes done before: Suggestion: an additional small dialogue A) Close with Save B) Close without Save (loosing all changes)

In addition the Save button could be active only, if there are really changes to be saved.

emyoulation commented 1 year ago

Careful consideration should given to implementation of something like this.

In other places that pop a "modal alert dialog" in Gramps, there is Preferences option to suppress the Alert/Warning. (So that workflow interruptions with modal confirmation dialogs can be eliminated. Such modal dialogs are an impediment for automation & "ease of access" accommodation.) Unless this "are you sure?" style of warning can be persistently suppressed, it should not be layered into the workflow.

Dimming the Save button when there is no changed/added Custom Filter to save would be nice feedback.

(A question... if the user edits/adds multiple filters in a session, does "Save" save the filter currently being edited? Or all the filters in the session? If it is the session, how do you avoid conflicts with the other parts of the GUI that also modify the custom filter list? -- the clipboard, the Filter gramplets, the object Filter Editor)

HelgeGitHub commented 1 year ago

Well, I understand and accept your comment regarding the additional dialogue. regarding your question: I would expect, that all changes would be saved. If one goes the way using the Edit button for a sub-filter via Define Filter dialogue, the changes will be saved (or cancelled) as decided by the user. The main dialogue of FilterParam is also the last level to decide Cancel or Save, if one changes directly using this dialogue. An alternate solution could be, that the FilterParam dialogue shows the situation only and all changes have to be done using the Define Filter dialogue via Edit button.