search

kkujansuu / gramps

MIT License
1 stars 1 forks source link

Save doesn't commit changes to filters #32

Closed emyoulation closed 1 week ago

emyoulation commented 1 year ago

After making changes to the parameters of a Custom Person Filter, I clicked the Save button.

The changes do not seem to be committed.

After closing FilterParams, I tried "Find" using in the Filter Gramplet and it matched against the original Parameter

Tried again but just switched to another Custom Filter in the FilterParams dialog and back. It reverted to the original Parameter

(Could I have disconnected the function from the button when tweaking that Glade file. I'm using the most recent repository version... without additional Glade changes.)

emyoulation commented 3 weeks ago

With the captured custom filter active in the Fan Chart's Filter+ gramplet: 1) tried tweaking (increase by 1) the Number of generations in Filter Params, clicked Save, clicked Find in Filter+. The results were not changed and using Edit in Custom Filter shows that the Parameter change was not committed. 2) tried the same tweak using Edit in Filter Params, clicked Save, clicked Find in Filter+. The results were not changed and using Edit in Custom Filter shows that the Parameter change was not committed.

Switched the active Custom Filter in Fan Chart's Filter+ gramplet: Repeated the same tests (but switching Filter+ back to the Saved filter before the "Find") with the same results.

image

kkujansuu commented 2 weeks ago

Fixed. Hopefully.

emyoulation commented 2 weeks ago

Nice! Works nicely on Gramps 5.2.1 on Fedora!

Please update FilterParams revision from 1.1.6