search

klabhub / neurostim

Design and run visual neuroscience experiments using Matlab and the Psychophysics Toolbox.
MIT License
5 stars 3 forks source link

Open ephys #106

Closed adammorrissirrommada closed 5 years ago

ltob2 commented 5 years ago

Awesome, thanks!

Lucas

On Thu, 29 Nov 2018 at 15:22, Adam Morris notifications@github.com wrote:

Merged #106 https://github.com/klabhub/neurostim-ptb/pull/106 into openEphys.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/klabhub/neurostim-ptb/pull/106#event-1994227391, or mute the thread https://github.com/notifications/unsubscribe-auth/AQsqqEdK634azWmvdY0tCuGZBhb3JHTUks5uz2EWgaJpZM4Y46uF .

cnuahs commented 5 years ago

Looks pretty good. the ePhys base class could (maybe should?) be an abstract class... and the start/stopRecording() and start/stopTrial() methods declared as abstract, to force a user (plugin developer) to implement the start/stopRecording() and start/stopTrial() methods in the derived class.

adammorrissirrommada commented 5 years ago

absolutely. yep.

On Thu, Nov 29, 2018 at 3:55 PM Shaun Cloherty notifications@github.com<mailto:notifications@github.com> wrote:

Looks pretty good. the ePhys base class could (maybe should?) be an abstract class... and the start/stopRecording() and start/stopTrial() methods declared as abstract, to force a user (plugin developer) to implement the start/stopRecording() and start/stopTrial() methods in the derived class.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://github.com/klabhub/neurostim-ptb/pull/106#issuecomment-442706319, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALcmT6roxXS1GOJAW9CQpKIwuiOrpBJOks5uz2jAgaJpZM4Y46uF.