klabhub / neurostim

Design and run visual neuroscience experiments using Matlab and the Psychophysics Toolbox.
MIT License
5 stars 3 forks source link

Updates to fixate and fixateThenChoose behaviours #122

Closed cnuahs closed 4 years ago

cnuahs commented 5 years ago

Some extensions to the fixate and fixateThenChoose behaviours. Specifically:

cnuahs commented 5 years ago

The default behaviour of fixateThenChoose is unchanged, and fixateThenChooseDemo works as before for me. Is there something you had in mind?

bartkrekelberg commented 5 years ago

Just to add something that shows the inflight option.

cnuahs commented 5 years ago

re: isStateXXX dependent properties,

I've been using them as a convenience in neurostim function strings when my 'stimuli' are dependent on the behaviour state... e.g., changing the fixation tolerance once the eye enters the window (e.g., something like f.tolerance = '@iff(fix.isFixating,1.5,1.0))'. A common method (in the base class) rather than dependent properties would probably require changes to str2fun()?

In any event, I agree this is a pretty specific use case and, while convenient, can probably also be achieved by comparing trialTime to startTime.STATE etc., and so maybe it should be discouraged.

bartkrekelberg commented 4 years ago

@adammorrissirrommada this pull request is waiting for your review.