Open adammorrissirrommada opened 4 years ago
I usually work with a version that is at least one, usually two cycles behind. So 18b or 19a now. But I would not consciously introduce new features that are so recent. Do we have anything in there that is not compatible with r2016b? (i don't have machines with such old versions of Matlab)
From: Adam Morris notifications@github.com Sent: Monday, February 3, 2020 12:04:30 AM To: klabhub/neurostim-ptb neurostim-ptb@noreply.github.com Cc: Bart Krekelberg bart@vision.rutgers.edu; Mention mention@noreply.github.com Subject: [klabhub/neurostim-ptb] Minimum MATLAB version (#141)
@bartkrekelberghttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fbartkrekelberg&data=02%7C01%7Cbart%40rutgers.edu%7Ce57f0c201949481213ea08d7a83446a7%7Cb92d2b234d35447093ff69aca6632ffe%7C1%7C1%7C637162814785810293&sdata=zif8nIzH4jZw0NSscy2y09kYZ2NAlRu4kPtVpQYMHWc%3D&reserved=0 , which version do you consider the minimum? Is it R2019a maybe? I'd like to update the check that is done in the CIC constructor. If it's a hard requirement, we also need to change it from warning() to error().
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fklabhub%2Fneurostim-ptb%2Fissues%2F141%3Femail_source%3Dnotifications%26email_token%3DAC3MRU3KSWKKSL7BCDDY7R3RA5GP5A5CNFSM4KO4WNH2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IKOGNHQ&data=02%7C01%7Cbart%40rutgers.edu%7Ce57f0c201949481213ea08d7a83446a7%7Cb92d2b234d35447093ff69aca6632ffe%7C1%7C1%7C637162814785810293&sdata=9qbGG9uamiExnaFVc8sbQohTh1sinKEXNDIXx3U1Pb0%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAC3MRUZ33U5LZJ6VSXI6JLDRA5GP5ANCNFSM4KO4WNHQ&data=02%7C01%7Cbart%40rutgers.edu%7Ce57f0c201949481213ea08d7a83446a7%7Cb92d2b234d35447093ff69aca6632ffe%7C1%7C1%7C637162814785820285&sdata=ELdmFwM8caEBuA3ijkfjbwZs28M0aJ1dQk%2BZRPjftjE%3D&reserved=0.
@bartkrekelberg , which version do you consider the minimum? Is it R2019a maybe? I'd like to update the check that is done in the CIC constructor. If it's a hard requirement, we also need to change it from warning() to error().