search

klabhub / neurostim

Design and run visual neuroscience experiments using Matlab and the Psychophysics Toolbox.
MIT License
5 stars 4 forks source link

Add ABC fixation symbol to fixation case structure #213

Closed ezavitz closed 2 years ago

ezavitz commented 2 years ago

The ABC fixation symbol is a pattern that enables the highest-stability fixation from human observers.

While adding a case to draw that pattern, also slightly modified other cases to create local copies of object properties for any properties that are accessed more than once.

adammorrissirrommada commented 2 years ago

This looks good to me. An extremely pedantic performance suggestion - only because this is by far the most used stimulus - might be to move your new switch case to the bottom, and while you are at it, move the CIRC one to the top, so that the most common switch case is found immediately.

adammorrissirrommada commented 2 years ago

Looks good to me. I'll let @bartkrekelberg sign off on it as the assigned reviewer.