search

klabhub / neurostim

Design and run visual neuroscience experiments using Matlab and the Psychophysics Toolbox.
MIT License
5 stars 3 forks source link

Removed the obligatory output plugin being added in cic and replaced … #65

Closed adammorrissirrommada closed 7 years ago

adammorrissirrommada commented 7 years ago

…it with saving of the cic object. This change would break any existing experiments that use the old plugin format for output. If they exist, they can either add the output plugin in their script or switch to Bart's new get() format.

Currently very rudimentary and probably not very clever. Saves on exit, and also on deconstruction. We've lost the "save every n trials" functionality that existed in the plugin version. Also, c.file, c.fullFile, and c.fullPath (new) exist, but it feels like these should be within the c.dirs structure (or that this is instead renamed c.output).

@bartkrekelberg Can you check whether this is a suitable approach for now and merge if so?

bartkrekelberg commented 7 years ago

I'm not sure about the change in beforeFunction in design: now only function_handles are allowed, previously a user could specify a neurostim function ('@bla') ... Why not allow that?

Removing output.m is fine.

adammorrissirrommada commented 7 years ago

I've restored it... though now I'm not sure how useful it is.... any changes you make to parameters are then overwritten with defaults or condition manipulations at the start of the first trial in the new block.

Check out my latest changes and merge if satisfied.