search

klaemo / popover

Small, composable popover component.
13 stars 5 forks source link

add method setButton #3

Closed kvnneff closed 9 years ago

kvnneff commented 9 years ago

This PR adds the public method setButton which accepts a DOM selector string or DOM element, and will update this.button and this.buttonCoords accordingly. This is useful when the button element does not yet exist or for reusing the same popover for different button elements.

klaemo commented 9 years ago

Good idea and the PR looks good :+1: Thank you!

klaemo commented 9 years ago

merged and published as version 2.3.0