search

klane11 / f1-3-c2p1-colmar-academy

0 stars 0 forks source link

SUBTLETY - width vs max-width #1

Open franfranfranfran opened 7 years ago

franfranfranfran commented 7 years ago

https://github.com/MaeDae11/f1-3-c2p1-colmar-academy/blob/master/Capstone%20Colmar/resources%20copy/css/index.css#L409

https://github.com/MaeDae11/f1-3-c2p1-colmar-academy/blob/master/Capstone%20Colmar/resources%20copy/css/index.css#L441

right before the page breaks to mobile view the content spills off the right hand side of the page. this is because you have a set width that is larger than the breakpoint. try using max-width instead of width to let these sections resize as the page is resized.

klane11 commented 7 years ago

Thank you so much, @franfranfranfran, for the notes throughout my code. This review is wonderful and insightful. I will definitely be implementing these changes soon.