klange / toaruos

A completely-from-scratch hobby operating system: bootloader, kernel, drivers, C library, and userspace including a composited graphical UI, dynamic linker, syntax-highlighting text editor, network stack, etc.
https://toaruos.org/
University of Illinois/NCSA Open Source License
6.03k stars 475 forks source link

BIOS loader keyboard input does not work in Bochs #255

Closed klange closed 1 year ago

klange commented 1 year ago

(Yes, I do actually test things in Bochs occasionally.)

Presumably since I switched to using BIOS routines to read the keyboard, it's not worked properly in Bochs. It seems we see a keyboard event during the timeout phase, but reading the keycode does not work as it should - pressing enter during the timeout, for example, does not immediately boot but instead brings us to the menu, where the arrow keys then do not work.

This is particularly annoying as it prevents booting Bochs into a VGA text-mode terminal, or disabling the read-write tmpfs migration, both of which are generally necessary to get a "not aggravating" experience in Bochs.

klange commented 1 year ago

The source of the issue was identified and resolved in 9d0bdb876ac41ebf0ca73336ba33e7dc01888aa7