klapo / pyfocs

Processing functions for Fiber Optic Distributed Sensing (FODS) data.
GNU General Public License v3.0
17 stars 11 forks source link

Should internal probes be dropped when using external reference? #58

Open klapo opened 3 years ago

klapo commented 3 years ago

The internal PT-100s from the Ultima or XT (i.e., probe1Temperature and probe2Temperature) are not being dropped when using external reference sensors.

Should the desired behavior be to drop any reference sensors that are not requested by the user in the config file? I could see potential cases where a user wouldn't use the reference sensor in the calibration but would want to keep those reference data around for later use.

klapo commented 3 years ago

Here is an example using data that had two external reference sensors and not the internal reference sensors. Note that probe1... and probe2... are present in addition to the expected warmprobe and ambientprobe.

<xarray.Dataset>
Dimensions:            (LAF: 17308, time: 3904)
Coordinates:
    calibration        (LAF) object '' '' '' '' '' '' '' ... '' '' '' '' '' ''
  * LAF                (LAF) float64 0.077 0.204 0.332 ... 2.2e+03 2.2e+03
  * time               (time) datetime64[ns] 2019-07-18T03:07:19.898000 ... 2019-07-18T06:53:58.880000
Data variables:
    Ps                 (time, LAF) float64 3.132e+03 3.113e+03 ... 948.0 951.6
    Pas                (time, LAF) float64 2.577e+03 2.581e+03 ... 716.6 700.8
    probe1Temperature  (time) float64 -200.0 -200.0 -200.0 ... -200.0 -200.0
    probe2Temperature  (time) float64 -35.65 -35.71 -36.89 ... -15.16 -14.53
    warmprobe          (time) float64 29.99 29.99 29.97 29.97 ... 32.5 32.5 32.5
    ambientprobe       (time) float64 17.39 17.39 17.39 ... 17.02 17.02 17.02
    logPsPas           (time, LAF) float64 0.1952 0.1873 ... 0.2816 0.3076
    cal_temp           (time, LAF) float64 -140.1 -146.5 -136.7 ... 19.99 15.29
Attributes:
    LAF_beg:             0.077
    LAF_end:             2199.791
    dLAF:                0.127
    calibration_method:  matrix
    calibration:         warmfar;warmnear;coldfar;coldnear