search

klaravel / db-logger

Laravel 5.3+ database queries logger
MIT License
13 stars 1 forks source link

Package should autocreate log directory #2

Open tmaly1980 opened 7 years ago

tmaly1980 commented 7 years ago

It's not mentioned in your instructions, but once installing your package, my app won't load and just gives a 500 error. I have to look into my log files to find out that the dblogger package isn't creating the necessary log folder. It's a bit of a nuisance and one more step that each developer has to remember when installing.

klaravel commented 7 years ago

@tmaly1980

Absolutely you point is valid.

When I did coding for check and folder not exits then add that will make performance down to check folder every sql query call with folder exits or not.

So made note on doc.

Note:

Make sure defined DB_LOG_DIRECTORY directory should be exists default direcotry is \storage\logs\db\ else application will throw error.

tmaly1980 commented 7 years ago

Realistically, the software should do it itself, so it’s one less command to run. Unfortunately, we’re a team of several developers so it’s one more step to our already complex process to get a site running on a new system.

On Jun 26, 2017, at 2:10 PM, K Laravel notifications@github.com wrote:

@tmaly1980 https://github.com/tmaly1980 Absolutely you point is valid.

When I did coding for check and folder not exits then add that will make performance down to check folder every sql query call with folder exits or not.

So made note on doc.

Note:

Make sure defined DB_LOG_DIRECTORY directory should be exists default direcotry is \storage\logs\db\ else application will throw error.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/klaravel/db-logger/issues/2#issuecomment-311137831, or mute the thread https://github.com/notifications/unsubscribe-auth/AHVz2y321w-Hfv2B2o1iOAqS3aDoTdikks5sH_QOgaJpZM4OFT-i.

klaravel commented 7 years ago

You are welcome to make pull request and I will merge after verify.

klaravel commented 7 years ago

Here is commit what I did on past for create folder and check but because of performance I have removed.

https://github.com/klaravel/db-logger/commit/34b3b5355d88537a3652dfad413cbbafa2bf5680