search

klarna / electron-redux

Use redux in the main and browser processes in electron
MIT License
743 stars 94 forks source link

fix: align enhancer style with standards to wrap the middleware #284

Closed sneljo1 closed 3 years ago

sneljo1 commented 3 years ago

As per my comments in #260. Unfortunately, I was unable to reproduce this using the tests, but in my setup using the redux-observable package I am having several issues. One of which is solved by aligning with the wrapping of middleware as used in the redux library itself. I think for some reason, in my case (some of) my middleware was overwritten by the middleware applied in the enhancer. Either way, my middleware was not properly executing, but after this fix, it is.

I did some extensive research but I was unable to find another library using a similar pattern of applying middleware in the enhancer instead of redux itself, so I do not know if this is 100% correct.

matmalkowski commented 3 years ago

:tada: This PR is included in version 2.0.0-alpha.7 :tada:

The release is available on:

Your semantic-release bot :package::rocket: