search

klarna / electron-redux

Use redux in the main and browser processes in electron
MIT License
743 stars 94 forks source link

use ipcRenderer.sendSync instead of remote.getGlobal #314

Open hanchaa opened 3 years ago

hanchaa commented 3 years ago

As of electron v10, enableRemoteMoudle is set to false by default, and I had to enable it for this library. And from v12, remote module was deprecated for security reason and it started to show warning message on devTools console. I found that getInitialStateRenderer is using remote.getGlobal so I substitute ipcRenderer.sendSync to it.

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

H-s-O commented 2 years ago

@victorhqc Can this be merged and published soon? I know there's version 2, but it's still technically in alpha stage and Electron is already at version 17, 3 versions after the remote module was removed.