klarna / react-native-zlib

Inflate/Deflate data compression via native code.
MIT License
24 stars 8 forks source link

Add homepage to Podspec #16

Open xuio opened 3 years ago

xuio commented 3 years ago

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch @klarna/react-native-zlib@1.0.1 for the project I'm working on.

this fixes issue #8

Here is the diff that solved my problem:

diff --git a/node_modules/@klarna/react-native-zlib/ios/RNReactNativeZlib.podspec b/node_modules/@klarna/react-native-zlib/ios/RNReactNativeZlib.podspec
index e7934a2..f501afb 100644
--- a/node_modules/@klarna/react-native-zlib/ios/RNReactNativeZlib.podspec
+++ b/node_modules/@klarna/react-native-zlib/ios/RNReactNativeZlib.podspec
@@ -6,7 +6,7 @@ Pod::Spec.new do |s|
   s.description  = <<-DESC
                   RNReactNativeZlib
                    DESC
-  s.homepage     = ""
+  s.homepage     = "klarna.com"
   s.license      = "MIT"
   # s.license      = { :type => "MIT", :file => "FILE_LICENSE" }
   s.author             = { "author" => "author@domain.cn" }

This issue body was partially generated by patch-package.

pcurc commented 3 years ago

I'd be very interested to see this patch implemented - CocoaPods refuses to install the current module as written and this solves the issue.

xhirazi commented 3 years ago

@xuio @pcurc use this https://www.npmjs.com/package/rn-gzip

xuio commented 3 years ago

@xhirazi Thanks! That is really helpful!

We previously had to patch this package manually to support GZIP's additions to zlib, but this makes things much easier!