search

klaro-org / klaro-js

Klaro Privacy Manager. An open-source, privacy-friendly & compliant consent manager for your website.
https://klaro.org
Other
1.19k stars 253 forks source link

Elements with role="dialog" or role="alertdialog" do not have accessible names. #503

Open lerni opened 6 months ago

lerni commented 6 months ago

Klaro Config Behaviour is present on klaro.org After updating to klaro 0.7.22, div#klaro-cookie-notice.cookie-notice has role="dialog" and causes PageSpeed to complain like: Elements with role="dialog" or role="alertdialog" do not have accessible names.

HTML Code of Page see above

Steps to reproduce Run PageSpeedInsights on klaro https://googlechrome.github.io/lighthouse/viewer/?psiurl=https%3A%2F%2Fklaro.org%2F&strategy=mobile&category=accessibility#aria-dialog-name

Current behavior After update to 0.7.22 PageSpeed starts to complain

Expected behavior No additional complaints after updating

Related to: https://github.com/klaro-org/klaro-js/issues/100

Edited 21st of May: I see now, that with v0.7.21, config.showNoticeTitle was introduced. Just showing aria-labelledby if config.showNoticeTitle is true would make sense IMHO.

Thanks for working on klaro !