klarsen1 / MarketMatching

Other
131 stars 37 forks source link

'prospective_power' is not an exported object from 'namespace:MarketMatching' #22

Closed iprice-sam closed 3 years ago

iprice-sam commented 3 years ago

I just installed MarketMatching from github and tried running the sample code for Pseudo Power Curves: https://github.com/klarsen1/MarketMatching#prospective-pseudo-power-curves

I get the following error:

Error: 'prospective_power' is not an exported object from 'namespace:MarketMatching'

Any ideas?

klarsen1 commented 3 years ago

Good catch. The readme is out of date. I'll update it.

I'll fix it. Also, the package is in CRAN. I'd use that one instead and check out the vignette instead of the readme.

The correct code looks like this. The function is called test_fake_lift(():

power <- MarketMatching::test_fake_lift(matched_markets = rollup, test_market = "TEST", end_fake_post_period = "2015-10-01", lift_pattern_type = "constant", steps=20, max_fake_lift = 0.05)

On Thu, Jan 14, 2021 at 6:02 AM iprice-sam notifications@github.com wrote:

I just installed MarketMatching from github and tried running the sample code for Pseudo Power Curves: https://github.com/klarsen1/MarketMatching#prospective-pseudo-power-curves

I get the following error:

Error: 'prospective_power' is not an exported object from 'namespace:MarketMatching'

Any ideas?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/klarsen1/MarketMatching/issues/22, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACNKU5CLZCPOSD73VPWMWALSZ32OLANCNFSM4WCPGBZQ .

iprice-sam commented 3 years ago

Got it. Thanks!