search

klarsen1 / MarketMatching

Other
131 stars 37 forks source link

Deprecated ggplot2 feature #30

Closed SeanRichterWalsh closed 10 months ago

SeanRichterWalsh commented 11 months ago

Hi,

Thanks for this awesome package. It is exactly what I have been looking for to help streamline my causal inference analyses.

I am getting the below warning message when using the latest version. I guess it is nothing too serious as it is related to ggplot visual components but wanted to raise the issue in any case.

The warning message seems to only appear when the argument analyze_betas = TRUE in the inference function is specified.

Cheers

Warning message: The <scale> argument of guides() cannot be FALSE. Use "none" instead as of ggplot2 3.3.4. ℹ The deprecated feature was likely used in the MarketMatching package. Please report the issue to the authors. This warning is displayed once every 8 hours. Call lifecycle::last_lifecycle_warnings() to see where this warning was generated.

SeanRichterWalsh commented 10 months ago

Closing this as I see it will be addressed in MarketMatching version 1.2.1