search

klattimer / LGWebOSRemote

Command line webOS remote for LGTVs
MIT License
523 stars 101 forks source link

Output an error message in case the `--name` argument is missing #134

Closed Tenzer closed 1 year ago

Tenzer commented 1 year ago

This will help make it more obvious for people upgrading that the argument now need to be specified.

See for instance https://github.com/klattimer/LGWebOSRemote/issues/118#issuecomment-1819307552.

Tenzer commented 1 year ago

I by the way noticed main.py doesn't seem to be used at all. Can it be removed?

Tenzer commented 1 year ago

Actually, would it be better to check for the commands first that don't require a TV name? I think it then would be easier to catch if a name is missing or if the command is mistyped.

I'm also thinking it might be nice to be able to configure a default TV which would allow people to not have to pass the --name argument to every command.

Tenzer commented 1 year ago

I have made a PR to set up a default TV name in #137 which would replace this change.

klattimer commented 1 year ago

Ok, you probably need to close this one if #137 over-rides it - but I like the idea of a warning message.

Tenzer commented 1 year ago

Handled via #137 instead.