klattimer / LGWebOSRemote

Command line webOS remote for LGTVs
MIT License
511 stars 99 forks source link

Debian Packaging Warnings #89

Closed barak closed 3 years ago

barak commented 3 years ago

I updated the debian/* packaging scripts a bit (see my fork) but even so lintian shows a bunch of minor issues. Would be nice to fix this up so it's a "regular" Debian package. Related: it downloads stuff during the build process, which Debian considers a no-no.

$ lintian ../lgtv_0.2-2_amd64.deb 
E: lgtv: dir-or-file-in-opt opt/venvs/
E: lgtv: dir-or-file-in-opt opt/venvs/lgtv/
E: lgtv: dir-or-file-in-opt opt/venvs/lgtv/.gitignore
E: lgtv: dir-or-file-in-opt ... use --no-tag-display-limit to see all (or pipe to a file/program)
E: lgtv: extended-description-is-empty
E: lgtv: no-copyright-file
E: lgtv: package-installs-python-pycache-dir opt/venvs/lgtv/lib/python3.9/site-packages/LGTV/__pycache__/
E: lgtv: package-installs-python-pycache-dir opt/venvs/lgtv/lib/python3.9/site-packages/__pycache__/
E: lgtv: package-installs-python-pycache-dir opt/venvs/lgtv/lib/python3.9/site-packages/certifi/__pycache__/
E: lgtv: package-installs-python-pycache-dir ... use --no-tag-display-limit to see all (or pipe to a file/program)
W: lgtv: description-synopsis-starts-with-article
W: lgtv: executable-not-elf-or-script opt/venvs/lgtv/lib/python3.9/site-packages/getmac-0.8.2.dist-info/LICENSE
W: lgtv: executable-not-elf-or-script opt/venvs/lgtv/lib/python3.9/site-packages/getmac-0.8.2.dist-info/METADATA
W: lgtv: executable-not-elf-or-script opt/venvs/lgtv/lib/python3.9/site-packages/getmac-0.8.2.dist-info/WHEEL
W: lgtv: executable-not-elf-or-script ... use --no-tag-display-limit to see all (or pipe to a file/program)
W: lgtv: package-contains-vcs-control-file opt/venvs/lgtv/.gitignore
W: lgtv: script-not-executable opt/venvs/lgtv/lib/python3.9/site-packages/chardet/cli/chardetect.py
W: lgtv: script-not-executable opt/venvs/lgtv/lib/python3.9/site-packages/pkg_resources/_vendor/appdirs.py
W: lgtv: script-not-executable opt/venvs/lgtv/lib/python3.9/site-packages/requests/certs.py
W: lgtv: script-not-executable ... use --no-tag-display-limit to see all (or pipe to a file/program)
W: lgtv: unusual-interpreter opt/venvs/lgtv/bin/chardetect #!/opt/venvs/lgtv/bin/python
W: lgtv: unusual-interpreter opt/venvs/lgtv/bin/easy_install #!/opt/venvs/lgtv/bin/python
W: lgtv: unusual-interpreter opt/venvs/lgtv/bin/easy_install-3.9 #!/opt/venvs/lgtv/bin/python
W: lgtv: unusual-interpreter ... use --no-tag-display-limit to see all (or pipe to a file/program)
X: lgtv: application-in-library-section python usr/bin/lgtv
I: lgtv: extra-license-file opt/venvs/lgtv/lib/python3.9/site-packages/LGTV-0.3.dist-info/LICENSE
I: lgtv: extra-license-file opt/venvs/lgtv/lib/python3.9/site-packages/certifi-2021.5.30.dist-info/LICENSE
I: lgtv: extra-license-file opt/venvs/lgtv/lib/python3.9/site-packages/idna-2.8.dist-info/LICENSE.rst
I: lgtv: extra-license-file ... use --no-tag-display-limit to see all (or pipe to a file/program)
I: lgtv: package-contains-documentation-outside-usr-share-doc opt/venvs/lgtv/lib/python3.9/site-packages/LGTV-0.3.dist-info/LICENSE
I: lgtv: package-contains-documentation-outside-usr-share-doc opt/venvs/lgtv/lib/python3.9/site-packages/LGTV-0.3.dist-info/entry_points.txt
I: lgtv: package-contains-documentation-outside-usr-share-doc opt/venvs/lgtv/lib/python3.9/site-packages/LGTV-0.3.dist-info/top_level.txt
I: lgtv: package-contains-documentation-outside-usr-share-doc ... use --no-tag-display-limit to see all (or pipe to a file/program)
X: lgtv: portable-executable-missing-security-features opt/venvs/lgtv/lib/python3.9/site-packages/setuptools/cli-32.exe ASLR DEP/NX
X: lgtv: portable-executable-missing-security-features opt/venvs/lgtv/lib/python3.9/site-packages/setuptools/cli-64.exe ASLR DEP/NX
X: lgtv: portable-executable-missing-security-features opt/venvs/lgtv/lib/python3.9/site-packages/setuptools/cli.exe ASLR DEP/NX
X: lgtv: portable-executable-missing-security-features ... use --no-tag-display-limit to see all (or pipe to a file/program)
klattimer commented 3 years ago

I will happily receive pull requests on this one, I haven't looked at Debian packaging in a long time so would rather someone with more up to date knowledge got on it.

I guess the dependencies need to be updated, in this case I think the patch to ws4py was the only bit which wasn't available as a dependency in Debian already. I believe that patch is merged and released now.

barak commented 3 years ago

Great! I'll give it a shot.

klattimer commented 3 years ago

can we close this now or was that just part 1?

barak commented 3 years ago

You can close it if you want to avoid cluttering up your issues. When (well, if) I get around to a big packaging fix, I'll issue pull reqs, coord if necessary, etc.