klattmose / klattmose.github.io

MIT License
22 stars 21 forks source link

Incompatible with FrozenCookies (browser) #47

Closed antimuffin closed 1 year ago

antimuffin commented 2 years ago

If I have both FortuneCookie and FrozenCookies [https://github.com/Icehawk78/FrozenCookies] loaded at the same time and cast any spell, FrozenCookies begins to season switch frantically, making it Easter followed by Not Easter as fast as it can until the price of season switching again is infinite, switching thousands of times in under a minute.

I've tried loading the two mods in different orders, changing settings, etc. Neither alone exhibits this behavior, so it's somehow an interaction between the two mods. I opened an issue over at the FrozenCookies repo first, since that is the most likely one that needs to be changed, but I wanted to alert you here as well.

erbkaiser commented 2 years ago

I suspect it's something in CCSE that messes up timer states. Just enabling CCSE on an empy save with FC already loaded, but nothing enabled, triggers countless 'Research has begun' pop-ups as well as unlock the Elder Nap achievement. This should be impossible of course. You can tell it's not Frozen Cookies causing this since nothing appears in the Javascript log and any purchase made by FC will be in there (unless Logging is disabled), and of course at this point FC AutoBuy is still disabled.

Enabling CCSE on an existing save with FC in late game causes other effects like non-stop purchase of seasons or the elder pledge. At this point it IS Frozen Cookies buying the switches but since it doesn't rebuy non expired timers without CCSE it must be CCSE messing things up.

TylorBane commented 2 years ago

im going to attempt to bump this since it seems it's not getting any attention, i just ran into this bug myself so i'd really enjoy if it's fixed

Hringingy commented 2 years ago

I'd also like to bump this issue in the hopes that this gets some attention

olaims commented 1 year ago

Is nobody taking care of this? 😢

TylorBane commented 1 year ago

Is nobody taking care of this? 😢

Unfortunately, while frozen cookies doesn't disable steam achievements, meaning that Orteil doesnt see it as cheating, that doesn't mean that the author of this mod is in any way required to make their stuff compatible with it, and is most likely ignoring it for that reason, i agree, it sucks, as i feel i should be able to play my single player game however i want, the author of ccse has no obligation to fix this and it most likely wont get any attention

NotWhiteRice commented 1 year ago

this is a mod handler, it should be compatible with other mods

erbkaiser commented 1 year ago

this is a mod handler, it should be compatible with other mods

If only... no, CCSE replaces Cookie Clicker functions with its own versions.

klattmose commented 1 year ago

To anyone still paying attention to this thread, if you could test out the beta version of CCSE (https://klattmose.github.io/CookieClicker/Beta/CCSE.js) for compatibility with Frozen Cookies, I would appreciate it. The frantic buying of Easter is fixed, but I'm not familiar with all the ins and out of Frozen Cookies to be sure that there aren't other, more subtle problems.

erbkaiser commented 1 year ago

Seems to work again with my fork of FC. Thanks, klattmose.

Also tested against my beta for 2.05. I can spot no more strange behaviour.

I'll edit the readme.

klattmose commented 1 year ago

Fixed in v2.034 of CCSE on browser. Steam version will be updated when the base game gets updated on Steam as well.