search

klaubert / waf-fle

WAF-FLE, ModSecurity Console
http://waf-fle.org
GNU General Public License v2.0
140 stars 74 forks source link

Added possibility to choose which IP address from IP header will be used #19

Closed sakalajuraj closed 9 years ago

sakalajuraj commented 10 years ago

When Client IP from header is checked (in sensor config), there are some situations where it is not desirable choose first IP as original Client IP. This patch is useful for example if you are behind proxy or load balancer and you are not interested in realy original IP address, but in the same time you want to view IP address that adds your proxy for your server.

sakalajuraj commented 10 years ago

Bad regular. I must close this pull request

klaubert commented 10 years ago

While this can be an option, I think that can be better, if your reverse proxy accept external xff, to set other header in your proxy with different name (not xff), this is the reason of header field in management menu.

Klaubert Em 21/07/2014 10:33, "Juraj Sakala" notifications@github.com escreveu:

Reopened #19 https://github.com/klaubert/waf-fle/pull/19.

Reply to this email directly or view it on GitHub https://github.com/klaubert/waf-fle/pull/19#event-143679210.

sakalajuraj commented 10 years ago

You are absolutely right. But there are situations, where you are not able (or not allowed) to do this or when the change is awful (and/or interfering with other settings). If I could choose between changing a lot of configurations or changing waf-fle behaviour, I would prefer changing waf-fle behaviour. I have no problem if you won't merge this pull request. If you want, simply close it.