search

klaudiosinani / ao

Elegant Microsoft To-Do desktop app
https://klaussinani.github.io/ao
MIT License
2.1k stars 198 forks source link

Fix Themes #117

Open kahless364 opened 4 years ago

kahless364 commented 4 years ago

This commit fixes all 3 themes to adjust for changes made on todo.microsoft.com, such as list groups.

Fixes:

99 The "Assigned to me" don't have the black theme background

113 Icons in themes broken

63 Text is a little too dark in Black/Dark themes

119 Today sidebar does not respect Dark mode setting

Screenshots: Sepia sepia-mode

Dark dark-mode

Black black-mode

Tests: No new errors (these are existing broken tests on master) tests

825i commented 4 years ago

You're a legend. Thanks for doing this @kahless364 !

Feromrk commented 4 years ago

Awesome! Just discovered this beautiful project and wanted to start digging into correcting the color of the font, which is too dark. But you did it already =)

825i commented 4 years ago

@kahless364 I've merged this with my own fork and credited you in the readme. Everything looks superb. Thanks so much. I'm going to make edits to my own branch because @klaussinani hasn't replied to any emails and seems to be busy on other projects.

Thanks again to both of you for your hard work. I'll do my best on maintaining my own fork. If anyone wants permission to make changes to it, feel free to ask.

haeringer commented 4 years ago

@kahless364 I've merged this with my own fork and credited you in the readme. Everything looks superb. Thanks so much. I'm going to make edits to my own branch because @klaussinani hasn't replied to any emails and seems to be busy on other projects.

Thanks @pythonInRelay for publishing a version with those fixes merged (and of course thanks to @kahless364 for the fixes themselves!). Do you have a hint for me how to install it from source on Linux or how to build a package myself? I have tried to create a snap with the below snapcraft.yaml, but the Multipass build fails with errors electron-builder not found and Failed to run '/root/parts/ao/npm/bin/yarn install --offline --prod although the electron-builder dependancy is listed in the package.json file. Sorry, got no experience with Electron... Am I on the wrong path maybe?

name: ao
base: core18
version: '6.9.1'
summary: Microsoft To-Do desktop app
description: An elegant Microsoft To-Do desktop app for Linux

grade: devel
confinement: devmode

parts:
  ao:
    source: https://github.com/pythonInRelay/ao/archive/6.9.1.tar.gz
    plugin: nodejs

apps:
  ao:
    command: ao
825i commented 4 years ago

@kahless364 I've merged this with my own fork and credited you in the readme. Everything looks superb. Thanks so much. I'm going to make edits to my own branch because @klaussinani hasn't replied to any emails and seems to be busy on other projects.

Thanks @pythonInRelay for publishing a version with those fixes merged (and of course thanks to @kahless364 for the fixes themselves!). Do you have a hint for me how to install it from source on Linux or how to build a package myself? I have tried to create a snap with the below snapcraft.yaml, but the Multipass build fails with errors electron-builder not found and Failed to run '/root/parts/ao/npm/bin/yarn install --offline --prod although the electron-builder dependancy is listed in the package.json file. Sorry, got no experience with Electron... Am I on the wrong path maybe?

name: ao
base: core18
version: '6.9.1'
summary: Microsoft To-Do desktop app
description: An elegant Microsoft To-Do desktop app for Linux

grade: devel
confinement: devmode

parts:
  ao:
    source: https://github.com/pythonInRelay/ao/archive/6.9.1.tar.gz
    plugin: nodejs

apps:
  ao:
    command: ao

Hey mate. I'm having a similar issue as I have no idea how @klaussinani managed to build this. I've been trying to make a .deb file out of it but I assume snap would be better for auto-updates. I'll let you know if/when I've cracked it or made any progress. Thanks for the info yourself though, but yeah unfortunately I'm no expert with Electron either. You too let me know if you manage to work it out. Thanks!

haeringer commented 4 years ago

Ahem... reading helps: I missed the development instructions in the readme. Indeed I was on the wrong path by using snapcraft; I was wondering already why there wouldn't be a snapcraft.yaml in the repository. ;) Simply running npm install and npm run release works just fine. Then install the snap via snap install --devmode dist/ao_6.9.1_amd64.snap (devmode because it's not signed by the Snap Store).

825i commented 4 years ago

Thanks for letting me know mate! I'll build it asap and put a package on the releases page on my Repo.

From: Ben notifications@github.com Sent: Sunday, February 2, 2020 4:47:51 PM To: klaussinani/ao ao@noreply.github.com Cc: Daniel Barber daniel.barber@edu.novia.fi; Mention mention@noreply.github.com Subject: Re: [klaussinani/ao] Fix Themes (#117)

Ahem... reading helps: I missed the development instructionshttps://github.com/klaussinani/ao/#development in the readme. Indeed I was on the wrong path by using snapcraft; I was wondering already why there wouldn't be a snapcraft.yaml in the repository. ;) Simply running npm install and npm run release works just fine. Then install the snap via snap install --devmode dist/ao_6.9.1_amd64.snap (devmode because it's not signed by the Snap Store).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/klaussinani/ao/pull/117?email_source=notifications&email_token=AN7KFKLKAZ5UXVMMOK2DVTDRA3TKPA5CNFSM4J2FCUZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKRZ22Y#issuecomment-581148011, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AN7KFKLVEJEBTFLHYUJKV2DRA3TKPANCNFSM4J2FCUZQ.

825i commented 4 years ago

Ahem... reading helps: I missed the development instructions in the readme. Indeed I was on the wrong path by using snapcraft; I was wondering already why there wouldn't be a snapcraft.yaml in the repository. ;) Simply running npm install and npm run release works just fine. Then install the snap via snap install --devmode dist/ao_6.9.1_amd64.snap (devmode because it's not signed by the Snap Store).

Managed to build and upload the release packages here: https://github.com/pythonInRelay/ao/releases/tag/6.9.1

A huge thanks to you @haeringer for helping with this. Looks great on my device. Just need to figure out a way to fix the white emoji background on dark themes if you use them in your To-Do lists.