search

klaudiosinani / hyper-pokemon

Tailor-made Pokémon themes for your Hyper terminal
https://klaussinani.github.io/hyper-pokemon
MIT License
1.04k stars 60 forks source link

Omanyte/Omastar Themes and PokeCursors mismatched #15

Closed SteadyMitch closed 7 years ago

SteadyMitch commented 7 years ago

Description

When selecting the Omanyte or Omastar themes, I see that the themes are mismatched so that selecting Omanyte in the configuration gives the Omastar theme in Hyper. Selecting Omastar in the configuration presents the Omanyte theme in Hyper. However the PokeCursor seems to match correctly with the selected theme in the hyper config

Screenshot 1 - Omastar, but Omanyte theme image

Screenshot 2 - Omanyte, but Omastar theme image

Theme settings

Settings for screenshot

// Hyper-Pokemon configs - Screenshot 1
pokemon: 'omastar', // Define your favorite pokemon theme! 
pokecursor: 'true', // Activate your theme's pokecursor! 
pokemonSyntax: 'light', // Define the color of the terminal tabs! 
unibody: 'true', // Define the color of the Hyper window header! 

// Hyper-Pokemon configs - Screenshot 2
pokemon: 'omanyte', // Define your favorite pokemon theme! 
pokecursor: 'true', // Activate your theme's pokecursor! 
pokemonSyntax: 'light', // Define the color of the terminal tabs! 
unibody: 'true', // Define the color of the Hyper window header!

Environment

OS: Windows 10 Hyper: 1.3.3 Hyper Pokemon: 0.3.1

tibuurcio commented 7 years ago

Thanks for taking the time to report the issue! 😄

I've created a PR to fix it here #16

If you want to get the right themes before a release goes out, go to $homeDir/.hyper_plugins/hyper-pokemon/backgrounds and swap the names for the Omanyte/Omastar background files and you're good to go!

SteadyMitch commented 7 years ago

Thank you @tibuurcio, that switched the themes for me. After switching, I found that I had to switch the unibody color in pokemon.yml also. Everything looks great, thank you for the quick response!

klaudiosinani commented 7 years ago

Hello @SteadyMitch! Thank you for reporting it! Feel free to share anything new you might come across! 😄 @tibuurcio Awesome work! 🎉 😄

SteadyMitch commented 7 years ago

Will do, thanks again for the great work! Definitely my favorite Hyper Theme by far 🥇

klaudiosinani commented 7 years ago

@SteadyMitch Haha thank you so much! Super happy that you enjoy it 😄