search

klaudiosinani / hyper-pokemon

Tailor-made Pokémon themes for your Hyper terminal
https://klaussinani.github.io/hyper-pokemon
MIT License
1.04k stars 60 forks source link

Always shows only pikachu background #29

Closed iamstevendao closed 6 years ago

iamstevendao commented 6 years ago

in the config.pokemon, I changed it to random, charizard, blastoise, ... full reload the terminal, close and open again but none of them works. It always shows the Pikachu background.
Any advice?

klaudiosinani commented 6 years ago

Could you please share your ~/.hyper.js configuration?

iamstevendao commented 6 years ago

@klauscfhq This is my config, I had been trying to re-install hyper as well as tried it out on my Windows laptop but both only show the Pikachu background.
screenshot_1

klaudiosinani commented 6 years ago

Moving only the 5 theme options directly below the colors object should fix the issue : ) Once done, you will be left with something similar to the following;

colors: {
...
},
pokemon: 'gengar', // Define your favorite pokemon theme
pokecursor: 'true', // Activate your theme's pokecursor
pokemonSyntax: 'dark', // Define the color of the terminal tabs
unibody: 'true', // Define the color of the Hyper window header
poketab: 'false', // Deactivate your theme's poketab
iamstevendao commented 6 years ago

@klauscfhq all good now, but do you think it's a better idea to wrap all your properties inside your theme unique property?
something similar like this:

colors: 
{
    //...
},
pokemonTheme: {
    pokemon: 'charizard', // Define your favorite pokemon theme
    pokecursor: 'true', // Activate your theme's pokecursor
    pokemonSyntax: 'dark', // Define the color of the terminal tabs
    unibody: 'true', // Define the color of the Hyper window header
    poketab: 'true', // Deactivate your theme's poketab
},

It is just my opinion so don't worry if you want to do differently xD.