search

klaudiosinani / hyper-pokemon

Tailor-made Pokémon themes for your Hyper terminal
https://klaussinani.github.io/hyper-pokemon
MIT License
1.04k stars 60 forks source link

Fix undefined variable #60

Open sairoutine opened 2 years ago

sairoutine commented 2 years ago

themes is not defined in getRandomTheme function. Therefore, if keys.length is 0, an uncaught error would be occur.

sairoutine commented 2 years ago

@klaussinani Hi! It seems that travis-ci has some troubles and does not work. Could you have any ideas to fix it?

klaudiosinani commented 2 years ago

@sairoutine Thank you for taking the time to contribute! I will have a look into the CI and review the PR asap

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information