klauer / blark

Beckhoff TwinCAT ST (IEC 61131-3) code parsing in Python using Lark (Earley)
https://klauer.github.io/blark/
GNU General Public License v2.0
42 stars 5 forks source link

Enhancement: support access specifiers for function block declarations #22

Closed engineerjoe440 closed 2 years ago

engineerjoe440 commented 2 years ago

Changes:

Closing Thoughts:

Please let me know if there are any questions or concerns with the changes! I have a few other enhancements I would like to contribute, and I want to make sure that my contributions are effective, and in-line with the direction you want to maintain.

Thank you so much!

engineerjoe440 commented 2 years ago

Thank you so much for your input and suggestions! I'm about to add some additional tests to test_transform to get some more coverage there. I'll try to keep that to one commit more for ease of review.

Thank you again for your willingness to guide and share your work!

engineerjoe440 commented 2 years ago

Thank you again for letting me muddle my way through this, and become familiar with your code-base. I really appreciate it! I think with this most recent set of commits, this PR should be ready for your review. :smile: