klauer / blark

Beckhoff TwinCAT ST (IEC 61131-3) code parsing in Python using Lark (Earley)
https://klauer.github.io/blark/
GNU General Public License v2.0
42 stars 5 forks source link

Add Github Action to Run Pytest for push/pull-request Actions #23

Closed engineerjoe440 closed 2 years ago

engineerjoe440 commented 2 years ago

Changes:

Closing thoughts:

I'm loving what you've got here in this project, and I want to use it in some of my work, but to do that, I need to enhance a few things. Before I start with too much of that, I wanted to bring in some automated testing to validate changes I make, and prove them out so that you're at least somewhat confident that my changes won't destroy your work.

engineerjoe440 commented 2 years ago

Thanks for being willing to allow contributions! If you're willing, I might add a few more CI plans for flake8 (since you pointed it out in the other PR I have open), and anything else I can! :)

klauer commented 2 years ago

Sure - that'd be great!

Just a thought, but you might consider just having pre-commit do the heavy lifting in CI (e.g., pre-commit run --all-files) instead of piece-meal flake8, isort --check-only, etc.