klauer / blark

Beckhoff TwinCAT ST (IEC 61131-3) code parsing in Python using Lark (Earley)
https://klauer.github.io/blark/
GNU General Public License v2.0
42 stars 5 forks source link

Enhancements and Fixes Found While Testing Code Base #36

Closed engineerjoe440 closed 2 years ago

engineerjoe440 commented 2 years ago

I've found a number of little things that were causing some trouble while I was testing this project against a number of 61131 repositories, I've made a bunch of smaller, incremental branches for each stage of work, so if you'd prefer going through one at a time, let me know!

Changes:

Closing Thoughts:

Please do let me know if you'd rather take a piecemeal approach to this, I've still got all of the branches, and we can work each one in separately. If there's anything that I've missed (clearly I've done that a time or two before), please let me know! I'm happy to get this all cleaned up.

I'm finding this project very useful, thank you!

klauer commented 2 years ago

I haven't forgotten about this - it's still on my TODO list. To your question, I'm OK with bunching these changes into one PR.

Hope to get back to you soon, and thanks! šŸ‘

engineerjoe440 commented 2 years ago

Don't worry about it! Heh! I wouldn't have been able to do anything this week if you asked for changes, anyway! Thank you!

engineerjoe440 commented 2 years ago

Woo-Hoo!!! Thank you @klauer !!!!! šŸŽ‰