klauer / blark

Beckhoff TwinCAT ST (IEC 61131-3) code parsing in Python using Lark (Earley)
https://klauer.github.io/blark/
GNU General Public License v2.0
42 stars 5 forks source link

Add Support of Chained Method/Function Calls #55

Closed engineerjoe440 closed 1 year ago

engineerjoe440 commented 1 year ago

Issues Addressed

Changes

Closing Thoughts

I think this is a fairly reasonable way to address this item, but I'm very open to comments or suggestions. I think it's possible to combine the original function_call_statement and this new function_call_statement_list but I left the original one for consistency sake. Let me know what you think!

codecov-commenter commented 1 year ago

Codecov Report

Merging #55 (5169bdc) into master (f423b1b) will increase coverage by 0.5%. The diff coverage is 100.0%.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/klauer/blark/pull/55/graphs/tree.svg?width=650&height=150&src=pr&token=QZDTKF30TH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=K+Lauer)](https://codecov.io/gh/klauer/blark/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=K+Lauer) ```diff @@ Coverage Diff @@ ## master #55 +/- ## ======================================== + Coverage 71.8% 72.4% +0.5% ======================================== Files 18 18 Lines 3772 3783 +11 ======================================== + Hits 2710 2739 +29 + Misses 1062 1044 -18 ``` | [Impacted Files](https://codecov.io/gh/klauer/blark/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=K+Lauer) | Coverage Δ | | |---|---|---| | [blark/tests/test\_transformer.py](https://codecov.io/gh/klauer/blark/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=K+Lauer#diff-YmxhcmsvdGVzdHMvdGVzdF90cmFuc2Zvcm1lci5weQ==) | `100.0% <ø> (ø)` | | | [blark/transform.py](https://codecov.io/gh/klauer/blark/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=K+Lauer#diff-YmxhcmsvdHJhbnNmb3JtLnB5) | `98.9% <100.0%> (+<0.1%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://codecov.io/gh/klauer/blark/pull/55/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=K+Lauer)
klauer commented 1 year ago

Thanks!