klauer / blark

Beckhoff TwinCAT ST (IEC 61131-3) code parsing in Python using Lark (Earley)
https://klauer.github.io/blark/
GNU General Public License v2.0
42 stars 5 forks source link

apischema as a non-optional requirement? #91

Open klauer opened 9 months ago

klauer commented 9 months ago

I'm considering making apischema a non-optional requirement. For those that are unaware, it's what allows blark to easily (de)serialize parsed code to/from JSON directly from the blark.transform dataclasses. It's currently made optional through a bit of hackery: https://github.com/klauer/blark/blob/abce326714cb9d4a7e0a2d6ad5d1cf8dc2c1110b/blark/transform.py#L26-L36

It's a reasonably light dependency, and it'd make things more convenient were it just a hard requirement.

Any thoughts, objections, emojis?

engineerjoe440 commented 9 months ago

Sounds perfectly reasonable to me!