PySide2 compatibility - Githubissues

klauer / qtpydocking

{{deprecated}} Qt-Advanced-Docking-System for qtpy (PyQt5 / PySide)

BSD 3-Clause "New" or "Revised" License

9 stars 6 forks source link

PySide2 compatibility #1

Closed MolotovCherry closed 5 years ago

MolotovCherry commented 5 years ago

Only minor changes needed to fix errors with PySide2

Mostly the parameters to certain functions changed and need to be handled differently between API's

Not 100% sure of the impact, but it works 100% fine for me, never noticed anything different. Please review it though

MolotovCherry commented 5 years ago

Fixed. I used the specific API boolean variables qtpy provided for more specificity. I also fixed some silent bugs. Pyside and PyQt4, in addition to PySide2, all do not support Qt.FindChildOptions. Only PyQt5 supports Qt.FindChildOptions. The program (probably) would've crashed when it ran into any of these in those API's.