search

klauer / qtpynodeeditor

Python Qt NodeEditor (qtpy, PyQt5, PySide)
https://klauer.github.io/qtpynodeeditor/
Other
186 stars 53 forks source link

Cyclic Connection #35

Closed Daguerreo closed 4 years ago

Daguerreo commented 4 years ago

The open issue https://github.com/paceholder/nodeeditor/issues/198 actually has a working solution in the comments. I integrated it long time ago and had a problem with that, I don't know why he isn't merging it though.

This porting has the same issue or do implement that fix?

klauer commented 4 years ago

The issue is in this port as well. My personal project that relies on qtpynodeeditor used networkx to get a digraph and break the cycles, but it's not as good as disallowing the connection creation to start with (plus, I'd rather not add the dependency here).

I think we could implement your suggested fix from the upstream issue, @Daguerreo.