klauer / qtpynodeeditor

Python Qt NodeEditor (qtpy, PyQt5, PySide)
https://klauer.github.io/qtpynodeeditor/
Other
192 stars 54 forks source link

FIX: attempted fix for #63 #64

Closed klauer closed 1 year ago

klauer commented 1 year ago

Description

When multiple nodes are selected and dragged around the graphics scene, sometimes the final positions of the nodes are not taken into account by the connection graphics objects.

This attempted fix simply makes note of the (node) dragging status of the entire scene, and makes all nodes update their connections one final time (post-mouse-up).

Motivation and Context

How Has This Been Tested?

Interactively. It appears to fix the disconnect noted in #63 as best I can tell.

That said, it's still not as smooth as you'd like from a node editor. I think the connection redrawing mechanism will need some refactoring to make that happen (specifically that connections should get redrawn in batches and not on an individual node basis... More for next time.)