klausahrenberg / WThermostatBeca

Replaces original Tuya firmware on Beca thermostat with ESP8266 wifi module
397 stars 97 forks source link

DST (daylight saving time) not switching back? #145

Open rrednaxela opened 4 years ago

rrednaxela commented 4 years ago

After falling back from DST to normal time on Sunday morning the time on my BHT-002-GALW didn't adjust. Today around 20:00 I clicked save on the 'Configure clock' page, and after the reboot the time was ok. I have configured the defaults, pool.ntp.org and time zone server http://worldtimeapi.org/api/ip How often does the software update the time? I have 2 thermostats on 1.18, same behavior on both.

fashberg commented 4 years ago

Klaus pulled that part of my fork and there was a bug in my Time Zone Implementation (mixed Northern and Southern Hemisphere).

Check https://github.com/fashberg/WThermostatBeca/issues/62 and https://github.com/fashberg/WThermostatBeca/commit/274a38e005c03d417e9893de388c6ef10d01b92f

fashberg commented 4 years ago

Nope. Completely different here and no Northern/Southern Mismatch https://github.com/klausahrenberg/WThermostatBeca/blob/master/WThermostat/src/WClock.h#L515 Then something different.

@rrednaxela You shoud share a screenshot of your TimeZone Settings

rrednaxela commented 4 years ago

@rrednaxela You shoud share a screenshot of your TimeZone Settings just the defaults image

Provided that the time was correct after reboot, it seems the condition in line 129 is not met? Or it never gets there? I looked a bit at https://github.com/klausahrenberg/WThermostatBeca/blob/4e76dfcdd6c806b34d6e25b9c61f4a6413d78874/WThermostat/src/WClock.h#L105

What is then the point of " (now - lastTimeZoneSync > 60000)" in L129? Only update timezone if last timezonesync was more than 1 min ago? If the whole loop anyway runs only every 3 hours?

martin072 commented 2 years ago

Bit of an old topic, but found out the same, but the other way around. DST settings were not applied after the 27th of March. I changed the NTP server to nl.pool.ntp.org, and after a reboot the time was correct again.

helmar74 commented 1 year ago

Same here today with version 1.36. Clock didn't change with this settings:

image