search

klausmeyer / fritzbox-smarthome

🏡 💡 Ruby client for AVM Home Automation Interface
https://rubygems.org/gems/fritzbox-smarthome
MIT License
6 stars 5 forks source link

allow to find actor by ain & reload #35

Closed klausmeyer closed 1 year ago

klausmeyer commented 1 year ago

See #34

klausmeyer commented 1 year ago

@carpodaster Thank you for 👀

I'm not at a machine where I can test it right now, but I'd be interested in benchmarks. My API responses are always comparatively slow. I wonder if only returning one record on the Fritz!Box end makes it significantly faster.

Would be interesting indeed.

In general the APIs are quite slow for me as well.

carpodaster commented 1 year ago

.oO0{ why can I review this PR in the first place? } :thinking: :smile:

klausmeyer commented 1 year ago

Guess in theory everyone can.

Might be some weird default in GitHub - but I actually like it.

I'll wait for the feedback from @mkoegel in #34 before merging.

Also need to put a few specs around the new stuff I guess ;)