search

klauspost / cpuid

CPU feature identification for Go
MIT License
1.04k stars 128 forks source link

Looks at CPUID leaves it should not #117

Closed DemiMarie closed 2 years ago

DemiMarie commented 2 years ago

A few months ago, @fosslinux reported that this code package looped forever under Xen. This has since been fixed, but it turns out that this code does not check if TOPOEXT is exposed before using it. Feel free to close if this has since been fixed.

DemiMarie commented 2 years ago

I see that the loop was fixed in 2a5efe88e9da9822cfdde4f6f68cf47b1202e86a but this code should not even try to query the cache values unless TOPOEXT is enabled.

klauspost commented 2 years ago

@DemiMarie Do you happen to have any link to documentation for that?

DemiMarie commented 2 years ago

@klauspost Not offhand, but it would be in the AMD programmer manuals.

klauspost commented 2 years ago

Added & Released

DemiMarie commented 2 years ago

Thanks @klauspost!