Closed pedrocr closed 8 years ago
It definitely makes the code much nicer on a quick look-through.
:) cool. I've done regression testing against all the files in rawsamples.ch and all of them are unchanged, so hopefully it's correct too. I pushed it to darktable master yesterday so our more adventurous users can find any potential weird bugs, but the regression testing coverage is usually pretty good at catching everything.
Cheers. It seems to almost only affect meta-data reading, so I this the cleaner code appears to be worth it.
Nice job!
This includes support for new RAF formats and then a bunch of safety fixes. afl-fuzz and AddressSanitizer are much happier now, but there is probably still a bit more to fix. This also includes a partial implementation of the ideas in issue #142. My next step will be to remove TiffEntryBE/TiffIFDBE entirely.