Closed LebedevRI closed 8 years ago
@klauspost friendly ping :)
And some more fixes:
cameras.xml
have only entries with mode="???"
, it did not work, thus breaking name demangling.@axxel i guess now you know how to contribute :) I have simply fixed it the way it did fix it. I did not benchmark and did not know about https://github.com/klauspost/rawspeed/commit/8e0ad84d91bce504a22ef6933de885f687bcf7c4
Benchmark it, and based on the results, possibly change code and PR it. As you can see, upstreaming changes into rawspeed is .. time-y process, so you may want to PR to https://github.com/darktable-org/darktable :)
@klauspost thank you!
All right, i guess it is time for a sync again.
Gist:
cameras.xml
. Will allow us in darktable to do some better checks during CI. Would have preventedRemove stray ">" in PENTAX K-70 ID.
nikon_override_auto_black
hint is no more needed, and was removed.musl libc
.Throw
inRawDecoder::setMetaData()
if nocam
. Prevents loading of broken images when guessing (failOnUnknown
) is disabled.Now what this does not fix: These 3 cameras got disabled:
They can be trivially re-enabled after a raw sample for each is found, to check white levels. Not sure, should i enable them in this pr, for upstreaming? May complicate upstreaming later on.
And, it was found that
NIKON D5100
is lying (duh), in this case it marks compressed raws as uncompressed, https://redmine.darktable.org/issues/11268, or at least it seems so.Special thanks to @schenlap.