klaussilveira / gitlist

An elegant and modern git repository viewer
https://gitlist.org/
BSD 3-Clause "New" or "Revised" License
2.92k stars 520 forks source link

spaces #544

Closed dogasantos closed 6 years ago

dogasantos commented 9 years ago

Hi, i have using git to sync some projects with several kind of files (NOT CODES) on my work. I use git instead of rsync because i want to keep track of every move.

But I cannot use GitList anymore because I'm getting in trouble with spaces in the name of files (i think it is a rewrite related issue, dont know for sure). An example of structure I have is:

gitrepo/Here Some Spaced Named Dir/Here some other spaced name dir/a nice file with spaces in the name.pdf

This will produce this error on gitlist:

Oops! fatal: Not a valid object name master:Here Some Spaced Named Dir/Here

Could you guys please take a look on this? I'll be VERY appreciated !! :D

dogasantos commented 9 years ago

UPDATE: There is another issue related to charset. I'm a brazilian guy and we use á é ç ã and others ascii chars supported by UTF-8, but i'm sill getting the same error described above.

xparq commented 7 years ago

I've just got this, when trying to open an item called "_junk/old code" in the repo browser:

Whoops, looks like something went wrong. 1/1 RuntimeException: fatal: Not a valid object name master:_junk/old

in /opt/sz/sys/pool/gitlist/dev-2017-02-16/vendor/klaussilveira/gitter/lib/Gitter/Client.php line 74
at Client->run(object(Repository), '-c "color.ui"=false ls-tree -l master:_junk/old code/') in /opt/sz/sys/pool/gitlist/dev-2017-02-16/vendor/klaussilveira/gitter/lib/Gitter/Model/Tree.php line 31
at Tree->parse() in /opt/sz/sys/pool/gitlist/dev-2017-02-16/vendor/klaussilveira/gitter/lib/Gitter/Repository.php line 483
at Repository->getTree(object(Tree)) in /opt/sz/sys/pool/gitlist/dev-2017-02-16/src/GitList/Util/Repository.php line 175
at Repository->getReadme(object(Repository), 'master', '_junk/old code/') in /opt/sz/sys/pool/gitlist/dev-2017-02-16/src/GitList/Controller/TreeController.php line 44
at TreeController->GitList\Controller\{closure}('lunawiki.git', 'master/_junk/old code')
at call_user_func_array(object(Closure), array('lunawiki.git', 'master/_junk/old code')) in /opt/sz/sys/pool/gitlist/dev-2017-02-16/vendor/symfony/http-kernel/Symfony/Component/HttpKernel/HttpKernel.php line 126
at HttpKernel->handleRaw(object(Request), '1') in /opt/sz/sys/pool/gitlist/dev-2017-02-16/vendor/symfony/http-kernel/Symfony/Component/HttpKernel/HttpKernel.php line 66
at HttpKernel->handle(object(Request), '1', true) in /opt/sz/sys/pool/gitlist/dev-2017-02-16/vendor/silex/silex/src/Silex/Application.php line 538
at Application->handle(object(Request)) in /opt/sz/sys/pool/gitlist/dev-2017-02-16/vendor/silex/silex/src/Silex/Application.php line 515
at Application->run() in /opt/sz/sys/pool/gitlist/dev-2017-02-16/index.php line 29
netbrothers-tr commented 7 years ago

This issue seems to be related to https://github.com/klaussilveira/gitlist/issues/714 and I think it should be reported to Gitter, too. What's your view on this?

xparq commented 7 years ago

Looks like you are right, yes, but I'm not familiar with the thing, if you're asking me.

netbrothers-tr commented 7 years ago

Well, I think we should ask @klaussilveira for a comment. :wink:

xparq commented 7 years ago

Hehe, that makes a lot more sense. :) I was coming from another thread somewhere with contributors having a discussion, and here in the apparent absence of Klaus I was stuck in that "chat" mode. (In fact, I was really puzzled why would you be asking me, so I just tried some neutral answer. :) But it's much better now, thanks for waking me up! :) )