search

klausw / hackerskeyboard

Hacker's Keyboard (official)
https://play.google.com/store/apps/details?id=org.pocketworkstation.pckeyboard
Apache License 2.0
1.83k stars 437 forks source link

Incomplete gradle wrapper #796

Open msrd0 opened 4 years ago

msrd0 commented 4 years ago

I just tried to compile this keyboard from source and it didn't work as expected. First, I just tried running gradle build which gave me some weird errors neither me nor the internet seems to have ever seen so I though maybe gradle 6.2.2 is too new and I should go for the gradle wrapper in the repository. However, besides the fact that gradlew was not marked executable, even after fixing that it doesn't run because the gradle folder is missing, that should contain the version info and the wrapper's jar file.

I believe those two files should be included in the repository, the gradlew (perhaps also gradlew.bat, no idea about windows) sholud be marked executable and as a bonus one could also note the minimum/maximum recommended gradle version in the build from source wiki page.

msrd0 commented 4 years ago

Note: I managed to compile the keyboard as follows:

  1. On ArchLinux, install the following packages:

    yay -S android-ndk android-platform-26 android-sdk android-sdk-build-tools-28 android-sdk-build-tools-28.0.3 android-sdk-cmake-3.6 android-sdk-platform-tools gradle4

  2. Update your environment: source /etc/profile

  3. Run gradle4 build

  4. The apk file is built: app/build/outputs/apk/debug/app-debug.apk