klaviyo / klaviyo-react-native-sdk

MIT License

4 stars 3 forks source link

CHNL-6305: Added set profile attributes bridge method #135

Closed ajaysubra closed 5 months ago

ajaysubra commented 5 months ago

Description

During the initial release of our beta react native SDK, we somehow missed bridging methods for setProfileAttributes on iOS. This PR aims to add those missing bridging methods.

Check List

[ ] Are you changing anything with the public API?
[ ] Are your changes backwards compatible with previous SDK Versions?

Changelog / Code Overview

Test Plan

Performed manual testing using different profile property attributes such as latitude, longitude, city etc.

Related Issues/Tickets

evan-masseau commented 5 months ago

iOS CI failed because of cached cocoapods mismatching with that lockfile change. I still don't understand why it is using cache if the lockfile changed. But I set off a re-run, which should ignore cache, lets see! Either way, I wouldn't hold up merging this due to the CI failure!

EDIT: NVM the re-run succeeded