klaviyo / klaviyo-react-native-sdk

MIT License

4 stars 3 forks source link

Reviewed sample app with an eye to android setup instructions and opened push event issues #153

Closed evan-masseau closed 3 months ago

evan-masseau commented 3 months ago

Description

I'm reviewing the sample app (mostly android) to make sure it contains and explains all the setup steps, similar to what Ajay's already done for iOS. These updates should help people get set up properly to avoid problems with opened push events also.

Check List

[x] Are you changing anything with the public API? -- NO
[x] Are your changes backwards compatible with previous SDK Versions? -- Yep

Changelog / Code Overview

Add missing setup to the android side of sample app
Commenting android code with all the steps
Some updates to readme and the iOS sample code

Test Plan

[x] When I finish, I'll confirm the sample app works and also go back through the test app to mimic these setup steps, where they differ.

Related Issues/Tickets

CHNL-7370

github-actions[bot] commented 3 months ago

This PR has not seen any updates in the last 16 days. Without further action this PR will be closed in 14 days. To disable further staleness checks add the evergreen label.