klaviyo / klaviyo-swift-sdk

SDK that allows users to incorporate Klaviyo's event and person tracking functionality within iOS applications. Written in Swift.

MIT License

10 stars 10 forks source link

Closed ndurell closed 5 months ago

ndurell commented 6 months ago

Description

Update Sample Projects to use the latest SDK.

[ ] Are you changing anything with the public API?
[ ] Have you tested this change on real device?
[ ] Are your changes backwards compatible with previous SDK Versions?
[ ] Have you added unit test coverage for your changes?
[ ] Have you verified that your changes are compatible with all the operating system version this SDK currently supports?

ajaysubra commented 5 months ago

Looks fine for the 2.4 version increment. Probably should make a point in the future to merge this before the release itself is published.

🤔 wouldn't you need the release to make the update?

Looks fine for the 2.4 version increment. Probably should make a point in the future to merge this before the release itself is published.

Hmm. Wouldn't you need the release in order to use it in the sample app? Unless I'm misunderstanding something.

ndurell commented 5 months ago

Looks fine for the 2.4 version increment. Probably should make a point in the future to merge this before the release itself is published.

I'm not sure you can release before it published.

evan-masseau commented 5 months ago

OH duh.